Kevin Rushforth
Kevin Rushforth
Reviewers: @johanvos @tiainen and one of @kevinrushforth or @arapte /reviewers 2 reviewers
> It will work like before, so there is no logical change. But still need a re-review. I retested all configurations. Correction: It isn't just a re-review that is pending....
@Maran23 I agree that the change @arapte noted above is fine, and your explanation makes sense. I did find one other difference in artifacts created. With the current master, running...
> > However, I also note that with this patch, even `gradle all` doesn't create `build/publications`. Consider adding a dependency to either `gradle sdk` or, more likely, `gradle all` so...
> > Either is fine, but having the `all` task depend on it seems a better choice (the fact that the `sdk` task currently depends on it seems somewhat arbitrary)....
Reviewers: @andy-goryachev-oracle @kevinrushforth
> Considering that the "left" and "right" terminology is deeply entrenched in JavaFX, I see no advantage in trying to fight it. However, I agree that we should clearly define...
Reviewers: @lukostyra @kevinrushforth /reviewers 2
@Maran23 This requires a new third-party library, which will need approval. Also, I'll need to review the PR. Since you didn't make any changes to the test source code, I...
I also don't see the hurry. Absent a compelling reason to update, we can wait for a while.