Kevin Rushforth
Kevin Rushforth
This is a risky change and will need to be carefully tested. Reviewers: @andy-goryachev-oracle @johanvos /reviewers 2 reviewers
> So although I agree that recreating is not needed as cell functionality is defined by their `update` methods, I do think this then requires a CSR. I agree. /csr...
@Maran23 Can you add the performance test program you ran to validate the performance numbers to this PR? A new directory under `tests/performance` seems a good place for it. I'll...
> There seems to be an intermediate test failure, maybe a race condition unrelated to this change: Yes, it is already filed and tracked by [JDK-8357459](https://bugs.openjdk.org/browse/JDK-8357459).
@Maran23 In case you missed it, this is pending changes from you. 1. I noted some final doc changes in [this comment above](#discussion_r2455868260). 2. I had added an [earlier comment](#issuecomment-3393245504)...
The API spec changes look good. I left a comment in the CSR that you need to add the changes made to `RadialGradient` (it looks good otherwise). I spot checked...
Without using an IDE (which is the default use case for manual tests), how would someone compile and run these? /reviewers 2
> On a related note, where is it documented how to run manual tests? It isn't documented anywhere. Nor are the tests wired up to the build. We have the...
I like the idea of a standard test utility, as long as there is some sort of build script or easy way to get at it. Probably not `build/testrun.args`, though,...