Kevin Rushforth
Kevin Rushforth
Reviewers: @beldenfox @kevinrushforth /reviewers 2
I'd like to review and test this, both in isolation and in connection with #1963 /reviewers 2
This approach seems much better than the previous in that it is activated only when a JavaFX Stage becomes the focused (key) window, and it saves / restores the menu...
As mentioned above, testing will be key here. This needs to work reliably in the case of a multi-window app when the application is hidden and restored, and when switching...
I note that your branch is very out of date. Please merge the latest master into your branch. There is a minor merge conflict in `modules/javafx.graphics/src/main/native-glass/mac/GlassWindow+Overrides.m` that you will need...
> I have rebased to the master To echo what the Skara said: next time, please _merge_ master instead of rebasing to master.. Rebasing makes reviewing new change since last...
Here are the assertion failures for the two failing tests: ``` MacOSSystemMenuMultiWindowFXOnlySwingLast > test() FAILED org.opentest4j.AssertionFailedError: Menu size is different: 5 != 2 ==> expected: but was: at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at...
> As long as manual tests are considered a good practice in such cases, I would be fine with it. This would of course mean that the test cases won't...
This is on my list to review this week. Sorry for the delay.
Not yet, but it's still on my list.