Kevin Rushforth
Kevin Rushforth
Reviewers: @johanvos @kevinrushforth @arapte We will need a unit test for this. What is the risk of regression? Are there additional tests that we could add to help detect any...
@hjohn Thank you for providing the additional analysis. This will help those of us who will review this proposed fix evaluate it to see if we can poke any holes...
> > It's not a bad idea to just run layout again if after running layout the root is still dirty. > > There must be historical reasons why this...
The idea seems interesting. It will need discussion on the mailing list, which I see you've started. /reviewers 2 reviewers /csr needed
Reviewers: @kevinrushforth @arapte
This will need careful review. Reviewers: At least two of: @lukostyra @arapte @kevinrushforth /reviewers 2
@notzed Please enable GHA testing for your repo. Go you your "Actions" tab in your repo and enable them with the green "enable workflows" button. Then push an empty commit...
@notzed As with the fix @arapte did for PR #1978, you will need to qualify this with `PrismSettings.isVsyncEnabled`. My quick take on your PR is that the changes are pretty...
Since this PR adds public API, it will need a CSR. And the new public methods will need API docs. You will also need to automated tests. > Question: should...
I was about to try and figure out why the lack of javadoc comments didn't fail the build. Then I noticed that the class in question, `ColorPalette.java`, is not a...