kennytm

> I would go so far as to argue that `any()` and `all()` are _better for formatting_. Binary operators used repeatedly have an awkward indentation problem. > > ... >...

> > I don't think it would be ambiguous here to reuse "feature" without adding "has_": `cfg(feature("asdf"))`. And this would also be consistent with other parts of cfg syntax. Technically...

@Jules-Bertholet the default rustfmt will not use vertical alignment. ---- @camsteffen Rust isn't afraid of having multiple ways to express the same concept, we have `for x in it {}`...

@breezewish Some customer chooses to skip the `ADMIN CHECKSUM` execution in Lightning (set `checksum = "off"`) and perform the check later manually. I'm not sure what to mean by "hiding"...

> If the struct declares this diagnostic attribute for trait Foo but also implements Foo, what should be done? Do nothing? The diagnostic is only consulted "on unimplemented", so it...

@cyqsimon When the type is generic e.g. `struct Map` it is perfectly logical to implement a trait for a subset of that type e.g. `T: Hash+Eq`. But you can only...

@cyqsimon > Would it be a good idea to emit a warning/error … Please note that the `#[diagnostic]` namespace RFC #3368 specifically mentioned: Any attribute in this namespace is not...

@cyqsimon They *can* (in the same way `#[diagnostic::something_invalid]` will generate a warning in place), but I don't think this is a blocking issue of the RFC. In fact, considering needing...

I think it is better to add a renderer that only renders the SVG path `code.render::().build()` that produces a string like `"M1 2h3v4h-3zM5 6h3v4h-3z"`, then you use this string inside...

> Unfortunately, it is not possible today to align the action with the comment. Note that Rust Style Guide specifically *avoids* visual-alignment (rust-lang/style-team#8, rust-lang/rustfmt#4108) because it is not diff-friendly (https://doc.rust-lang.org/stable/style-guide/principles.html)....