Keegan Carruthers-Smith
Keegan Carruthers-Smith
Thank you!!
Hopefully we can get away with just the libraries we rely on being updated. Although, if I am not mistaken we have some code which makes assumptions about how code...
To be honest I am not sure. For our "slower" gotodef it probably does help. For our faster "godef" version I think it is less likely to help.
@marwan-at-work Master now has all dependencies updated, including recent changes to `golang.org/x/tools`. That _might_ just get it to work. However, we still have code which inspects stuff based on GOPATH,...
cc @chrismwendt
I assume we should make the limit much higher than 100 then. Also do we have any concerns around quality of results when we start to limit. Previously we sorted...
I have added https://github.com/sourcegraph/go-langserver/pull/173 which adds a limit param to xrefs. I think once that lands, we can close this out. However, we still need to update the spec and...
Thanks for the link. I see the gocode README now suggests the switch, so this makes sense to me.
Yeah that makes sense to me. A PR for what you have done sounds GTM. It may make sense to use a fork of `mdempsky/gocode` which we pull in via...
> My plans was to copy only needed mdempsky/gocode into go-langserver I think we should switch to using a fork (or trying to get it being a library upstream), so...