Keegan Carruthers-Smith

Results 154 comments of Keegan Carruthers-Smith

@sandipb thanks, that is a good lead on what is going wrong and surprising to me. If you re-install the langserver using the same version of Go you are developing...

cc @sourcegraph/search-platform

What is the status of this PR? What can I do to help unblock/land?

> In short, this changes the definition of a "line" in a chunk to include its terminating newline (if it exists). This sounds good and correct to me. > So,...

> @keegancsmith, this is ready for review now. It doesn't look we do any "release" for Zoekt -- any thoughts about how to publicize this since it is a breaking...

Sorry and thank you @isker!

I'm interested in why using `aws-go-sdk` is an improvement? Also I believe prometheus has built in AWS service discovery now, I should probably update the description.

I'd be keen to take in this PR without the vendoring in. You can however leave the `vendor.json` lieing around.