Keegan Carruthers-Smith

Results 154 comments of Keegan Carruthers-Smith

@kevinburke Find implementations finds methods which implement an interface methods. What you are referring to is find references. In this case it works https://sourcegraph.com/github.com/kevinburke/aws-vault/-/blob/vendor/gopkg.in/alecthomas/kingpin.v2/global.go#L84:6=&tab=references

[goreleaser](https://github.com/goreleaser/goreleaser) looks cool and easy to setup. Lets do it, happy to accept a PR that integrates it.

Nice catch with both the upstream issue in gocode and it printing to stderr. We actually need to switch to https://github.com/mdempsky/gocode anyways. We probably need to work out a way...

It triggered a data race which I haven't seen before! I filed https://github.com/sourcegraph/go-langserver/issues/244 but it looks very much unrelated to your code. Restarted the CI job. Thanks for the ping.

Thanks, I just read the spec for `MarkupContent`. It seems a hover can now return ```typescript contents: MarkedString | MarkedString[] | MarkupContent ``` and that `MarkupContent` is somewhat equivalent to...

We also use godef as well. The use of `.` imports is discouraged and linting tools actually complain if you use them outside of a package test https://github.com/golang/go/wiki/CodeReviewComments#import-dot As such...

@RahmanQureshi I would suggest migrating to [gopls](https://github.com/golang/tools/blob/master/gopls/doc/user.md)

This issue is for another language server. You likely need to file an issue against gopls. https://github.com/golang/tools/blob/master/gopls/doc/troubleshooting.md#file-an-issue

Yup, I meant to add a basic test for all languages. The point of the tool is then to easily just do `lsp-record test haskell` and if it says yet...

Yeah windows is mysterious to me and I don’t have an env for it to iterate. I did quite a few attempts via appveyor to work it out, but gave...