Keegan Carruthers-Smith
Keegan Carruthers-Smith
Thanks for the report, should be an easy fix.
I thought this would be easy to solve, but it ended up being a pretty deep change. Hopefully https://github.com/sourcegraph/zoekt/pull/843 resolves this for you.
This is quite github specific feature request. However, maybe a more generic "repository labels" would make sense here. For example we already have this sort of idea for supporting filtering...
Sorry that linear issue comment we just use at Sourcegraph to help not lose track of stuff. All issue tracking for zoekt happen on this github issue tracker.
I've assigned it to you to make it clear you are interested in implementing this.
Ok there are issues here. The issue is boils down to how we changed normalization between the two versions of the package. I actually have bigger concerns around this now....
> Let's move the `lib/codeintel/languages` package to a public repo and add a dependency on that? Otherwise, having to maintain this copy separately is going to get tedious quickly, and...
Does this change make sense? Should we keep in our application code the idea of if we should create a trace or not, or is that all magically handled somehow...
Thanks for the comments! I haven't forgotten about this PR, I'm just focussed on other projects at the moment. We do use OTEL, but not "natively". IE it all goes...