Kris Kristoffer Dreher

Results 35 comments of Kris Kristoffer Dreher

I'm using PyCharm and adding environment variables to the run configuration worked but since we'll call everything else in simpa in a script, I wanted to set them there. Yes,...

The only thing that would come to my mind would be that according to [PEP8](https://peps.python.org/pep-0008/#imports), imports should be at the top without constant declarations or else. Other than that, I...

Yes, I guess we should add it to all directions probably in both `simulate_2D.m` and `simulate_3D.m`

What numpy version do you have? The `dtype` argument was introduced in numpy version 1.24.0

This issue should be resolved by now

This has been worked on and implemented in #290

Thanks for reporting this and for using the new issue template! :) In one of your screenshots, it says that you use the simpa version 0.8.11 which is an older...

The solution with `pgk_resources ` keeps causing problems so we will need to find a different one

> All changes look good to me 👍 > > When running the manual tests there are differences between the reference and the test results. Especially in kwave simulations and...

With this commit: 4847fd31a93c19909dcd1fdbb4eeedfc28e09703 I changed the dependency to pacfish. However, since the API changed a lot, I the pacfish adapter now raises an error on instantiation and the tests...