Kris Kristoffer Dreher comments

Results 35 comments of


                                            Kris Kristoffer Dreher

The Rayleigh Scattering is not correct.

Yes, you're absolutely right. Not only this but also, everywhere we use this function, we use it as scattering coefficient instead of the reduced scattering. We're directly testing certain scattering...

TestPathManager test_instantiate_without_file fails with existing `path_config.env

Fixed by #347

Vessel structure shouldn't vary (this much) as a function of the wavelength

Thank you! I just took a look and the problem is that we only set the numpy seed and not the torch seed, too. I will put a PR soon.

3D PA simulation question

It is difficult to say what could be the problem. Could you send the log of the error message? If possible, you can also send the tiff file that you...

Seem impossible to simulate with different laser energies depending on the wavelength

Yes, you're right. [Here](https://github.com/IMSY-DKFZ/simpa/blob/6949c2c35dd7a0022586cc68e693df60e0a22611/simpa/core/simulation_modules/optical_module/optical_adapter_base.py#L98), we just take whatever value is set in the `component_settings`. So if there's an iterable given, this will not really works. But this is easily fixable...