Kevin Newton comments

Results 168 comments of


                                            Kevin Newton

Fix evaluation order issue in f(**h, &h.delete(key))

Hey @jeremyevans — yes sorry I've been working on a bunch of stuff this week so didn't get the time. I'll look at this first time next week.

Add links to code refs in docs

Superseded by https://github.com/ruby/prism/pull/3640

Deprecate `Prism::Translation::Parser`

Sorry I'm just now coming back to this. My idea was that we would always update this class to be the latest released version, so that people wouldn't need to...

Inconsistent line numbers for Method.source_location

I think `parse.y` is wrong here, the block clearly starts on line 3. I will bring this up for discussion.

Expose prettyprint/serialize/parse options in rust

I'm okay with prettyprint and the parse options, but I'm not sure I understand the use case for the serialization API in rust. Could you explain the motivation?

Expose prettyprint/serialize/parse options in rust

@segiddins Thanks for your patience. I'm fine accepting the options from the rust side (I definitely think we should do that). I'm much less keen to expose the serialization format....

Requesting new release

v1.5.0 is released.

Feature request for an API to check if a syntax invalid code can be syntax valid by appending continuation tokens

If you get: ``` def foo a + end tap do ``` right now it would match `:recoverable_error`. What is the desired behavior in this case? You would need to...

Feature request for an API to check if a syntax invalid code can be syntax valid by appending continuation tokens

Yes, I would like to support this API. I assume it would be on the `Prism::ParseResult` class, and it would be something like `ParseResult#recoverable?` or something to that effect.

Bug: Double Apostrophe in <value> URI Formatting Issue

I'm not sure if this is a bug or not. You're setting it to "preserve", which means in some cases we keep the whitespace and in some cases we do...