Kevin Newton

Results 168 comments of Kevin Newton

You're absolutely right, I'll keep going. Thanks @tompng!

This does not seem like an issue with the plugin, but more with prettier configuration. I've moved this to the central prettier repository.

Superseded by https://github.com/ruby/prism/pull/3641

> `"\xc2A".valid_encoding?` is false, but should `"\xc2A".forcible_encoding?("UTF-8")` be true? That's a good point! I think it should probably return `false`. I will update the PR.

@byroot so I addressed this in https://github.com/ruby/ruby/pull/11912. I _mostly_ fixed it. I tried to change `iseq.c` in the free function to `rb_bug` where it checks `->table` but there was still...

Can you give me a text XML file where this happens? I have not found an example. If there is a test you could add, that would be great. I...

I don't think you're doing it wrong, but is it possible you're using an earlier version of the plugin? I cannot get it to crash with the latest version.

I don't think so, if I run this in bun or safari it passes. I would be shocked if this had anything to do with the runtime as it's a...

I think I will leave this as part of your extension, because I cannot figure out how to reproduce this.

I'm not going to make a configuration option for this, but I am open to changing the default behavior here. Are we okay with saying that: ```xml ``` gets reformatted...