Kevin Newton

Results 160 comments of Kevin Newton

Hey there. I definitely see what you're saying here, we really shouldn't be parsing formatted syntax errors, that's difficult. From Prism's perspective (this repo specifically) all we do is bundle...

@aaronjensen do you have the ability to use Prism itself? You could parse the code with `Prism.parse` and then will have access to an array of errors with location information...

You can get the warnings off the parse result as well, they're in there on `Prism.parse_stream(STDIN).warnings`. So in theory that should alleviate some of it?

I fear you'll need a version check either way, as whatever changes I made wouldn't be backported to 3.4 since they wouldn't be considered a "bug". So even if I...

I've opened https://bugs.ruby-lang.org/issues/21573 to discuss this with Ruby core.

I'm not sure if this is necessarily going anywhere upstream, but I'll keep that ticket open and keep asking. In the meantime, I would suggest using Prism as suggested above.

@tenderlove make sure you don't merge this before we get this working in ruby/ruby using the new API, otherwise this is going to break a bunch of stuff. I've been...

I'll start testing this in ruby/ruby and see what changes are necessary. In the meantime I'm going to label this PR as "blocked" just to indicate that it should not...

Hey @jeremyevans — I pushed a fix for Prism in a separate commit. Let me know if there's any other issues!