Kevin Newton

Results 59 comments of Kevin Newton

cc @gmcgibbon since you kindly merged the last one

I think this is fine, but I'd really like to understand the implications of removing the FIELD usage here. If it's got no impact on indexed or non-indexed columns it's...

I'm 👍 on either approach at this point (keeping the behavior around when there's no `nil` and using `super` or just rolling with one method). I think either is fine....

I'm not sure I understand the logic of that graphic. Why is it that the whitespace within the `` tag is significant but the whitespace within `` is not significant?...

That's not my understanding of the XML spec. From what I understand unless you specify an `xml:space` attribute or you're using a DTD schema, all whitespace outside of tags is...

I've opened an issue on the upstream parser here: https://github.com/SAP/xml-tools/issues/407.

Closing this as it's being tracked over on that other issue. Sorry about this @luisg123v I'm at the mercy of the parser. If you feel like a contribution, that'd be...

Yeah I'd be super open to this. It would involve just rewriting the options before they're passed to the child process here: https://github.com/prettier/plugin-ruby/blob/d1eb56712d055c3305c9dd2eccafb0085d703be6/src/parseSync.js#L119. Feel like taking a shot at it?