Karthikeya Remilla
Karthikeya Remilla
@ejbrever could you please take a look at the improved code now?
Waiting for approval from @ahsaanyousaf
@rohit-rp is the ATE version of LLDP not used anymore? I think it is deleted? If so, we can close this PR, as it is not applicable anymore as the...
@ram-mac please review again as I've made the requested changes.
@dplore could you please merge this if accepted?
> @karthikeya-remilla this test is not passing on Cisco in our environment. Before we can merge, I'd like to see this passing. What are we missing? This is a 24.4.1...
> Please note test is not passing in our environment and static check fix Please review the logic while I work on static check and merge conflicts in metadata.pb.go.
updated PR description
> Hi @karthikeya-remilla can you resolve the merge conflict with proto/metadata_go_proto/metadata.pb.go? I will and merge this after resolved. Hi @dplore , resolved the conflicts. Could you please check now as...
> Please fix the test .. this fix is not working Hi Ram, I am looking into this internally and will get back to you once I have an update.