openconfig
healthz parameters for cisco
a. added the process "ifmgr" for test purposes and chassis component name "Rack 0" for Cisco The test intent is to kill a process and perform Healthz operations post that. So functionally any software process is valid for this purpose on Cisco IOS-XR platform b. Origin as "openconfig" for healthz RPCs
Pull Request Functional Test Report for #3326 / a92702ed5514c9221be3e246016146bf73daf030
Virtual Devices
Hardware Devices
Pull Request Test Coverage Report for Build 11375744222
Details
- 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 55.268%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| internal/components/components.go | 0 | 8 | 0.0% |
| <!-- | Total: | 0 | 8 |
| Totals | |
|---|---|
| Change from base Build 11375559091: | 0.0% |
| Covered Lines: | 1983 |
| Relevant Lines: | 3588 |
💛 - Coveralls
@karthikeya-remilla this test is not passing on Cisco in our environment. Before we can merge, I'd like to see this passing. What are we missing?
Details
``` # show version
Wed Aug 14 15:09:11.997 PDT Cisco IOS XR Software, Version 24.3.1.28I LNT Copyright (c) 2013-2024 by Cisco Systems, Inc.
Build Information: Built By : sajshah Built On : Thu Aug 08 10:33:18 UTC 2024 Build Host : iox-ucs-002 Workspace : /auto/iox-ucs-002-san2/prod/24.3.1.28I.SIT_IMAGE/8000/ws Version : 24.3.1.28I Label : 24.3.1.28I-EFT2_rev2
=== RUN TestCopyingDebugFiles third_party/openconfig/featureprofiles/feature/gnoi/system/tests/copying_debug_files_test/copying_debug_files_test.go:67: *** Fetching gNOI clients for xx27.den85... third_party/openconfig/featureprofiles/feature/gnoi/system/tests/copying_debug_files_test/copying_debug_files_test.go:73: process bgp not found on device --- FAIL: TestCopyingDebugFiles (18.11s) === RUN TestChassisComponentArtifacts third_party/openconfig/featureprofiles/feature/gnoi/system/tests/copying_debug_files_test/copying_debug_files_test.go:120: *** Fetching gNOI clients for xx27.den85...
third_party/openconfig/featureprofiles/feature/gnoi/system/tests/copying_debug_files_test/copying_debug_files_test.go:137: Executing Healthz Check RPC for component Rack 0
third_party/openconfig/featureprofiles/feature/gnoi/system/tests/copying_debug_files_test/copying_debug_files_test.go:140: Unexpected error on executing Healthz Check RPC: rpc error: code = Unimplemented desc = error on request {
path: {
origin: "openconfig"
elem: {
name: "components"
}
elem: {
name: "component"
key: {
key: "name"
value: "Rack 0"
}
}
}
}: unknown service gnoi.healthz.Healthz
--- FAIL: TestChassisComponentArtifacts (0.76s) FAIL
</p>
</details>
ALso, I realize this is not directly part of your PR, but can you fix the following static checks?
https://github.com/openconfig/featureprofiles/actions/runs/10386614180/job/28769839021?pr=3326
Error: internal/core/core.go:215:10: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
Error: tools/internal/ocpaths/ocpaths_test.go:167:5: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
Error: Process completed with exit code 1.
@karthikeya-remilla this test is not passing on Cisco in our environment. Before we can merge, I'd like to see this passing. What are we missing?
This is a 24.4.1 feature. This failure is expected on 24.3.1
Please note test is not passing in our environment and static check fix
Please review the logic while I work on static check and merge conflicts in metadata.pb.go.
Hi @karthikeya-remilla can you resolve the merge conflict with proto/metadata_go_proto/metadata.pb.go? I will and merge this after resolved.
Hi @karthikeya-remilla can you resolve the merge conflict with proto/metadata_go_proto/metadata.pb.go? I will and merge this after resolved.
Hi @dplore , resolved the conflicts. Could you please check now as the FR is delivered?
@karthikeya-remilla there are a few static check errors to be resolved.
I am not sure why we seeing this panic in go test? Are you seeing that when you run locally @karthikeya-remilla ?
Ref to broken github check: https://github.com/openconfig/featureprofiles/actions/runs/10744182024/job/29800536390?pr=3326#step:6:443