featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Cisco logical channels

Open karthikeya-remilla opened this issue 1 year ago • 2 comments

Changes for zr_logical_channels_test:

  1. operationalMode flag
  2. cisco numbering deviations for eth and otn channels
  3. eth and otn channels' index testcases based on deviations

Note: ciscoOpticalChannelFormat := strings.ReplaceAll(opticalChannel, "/", "_") // Ex: OpticalChannel0_0_0_18

This is temporary line under the deviation till Cisco supports OpticalChannel in standard OpticalChannel0/0/0/18 format. Internal bug raised and in progress.

karthikeya-remilla avatar Sep 27 '24 14:09 karthikeya-remilla

Pull Request Test Coverage Report for Build 11898205731

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11886246328: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

coveralls avatar Sep 27 '24 14:09 coveralls

@ejbrever could you please take a look at the improved code now?

karthikeya-remilla avatar Oct 04 '24 05:10 karthikeya-remilla

Waiting for approval from @ahsaanyousaf

karthikeya-remilla avatar Oct 07 '24 14:10 karthikeya-remilla

@amrindrr please run and verify this and if good, you can merge it

dplore avatar Oct 10 '24 21:10 dplore

Please resolve the conflicts so this can be merged.

ahsaanyousaf avatar Nov 06 '24 21:11 ahsaanyousaf