Karl Gordon

Results 87 issues of Karl Gordon

Would be good to standardize the plotting outputs to allow for screen viewing or saving to a file (pdf, png, etc.). Some of the plotting scripts support this, some have...

plotting
effort-low

Need to expand the prior models to support megabeast ensemble models. - IMF: needs to include min/max masses and varying the slope(s) - AMR: need to include bins_histo as a...

stars
dust
effort-medium
megabeast

Currently runs fails if some of the intermediate hd5 files exist in the output directory. The workaround is to delete these files before each run (or the entire output directory)....

bug
effort-medium

The stellar grid is currently based on isochrones. This the grid has uniform spacing in age, but non-uniform in mass. Isochrones are best for dealing with ensembles of stars, but...

stars
effort-high

The beast tests are failing on windows. This has only been revealed with the move to github actions for testing as that is when windows testing was added. The issue...

bug
stars
tests
effort-low

Using /tmp as a place to store files can be insecure. Causing a warning in Codacy. Should be fixable using tempfile.NamedTemporaryFile from the python tempfile module.

bug
tests
effort-low

Currently read_sed_data directly accesses the SED data from disk via h5py. If possible, would be good to switch this to using the SEDGrid class to allow for other formats and...

bug
enhancement
effort-medium

In the phat_small example, the saved lnp data has inf/nan values. Not sure this is expected/correct/handled. for star 11 (e.g., using `read_beast_data.read_lnp_data(), lnp_data['vals'][10]`) ``` lnp_data['vals'][10] = [ -inf -inf -14.52056885...

bug
fitting
effort-medium

The tools and plotting functions need to be added to the API.

documentation
effort-low

Would be good to add testing the pdf2d creation as part of the test_fit_grid.py test. This emerged from the review of PR #553.

tests
effort-low