Karl Gordon
Karl Gordon
If understand things correctly, the tests are failing as the version of stcal used for the tests does not include the changes needed for this PR. After the stcal PR...
Ready for review. Likely, the corresponding PR in stcal should be reviewed at the same time.
> @karllark I think this PR branch may need to be rebased from master. Looks like conflicts are preventing the CI tests from running. Done.
Done with the extinguish function for the Rv dependent models Will require more work for models without Rv, new extinguish command that requires Rv?
I have not looked at Spectrum1D yet. I will. One concern I have is it would be nice to have functions that work with data other than Spectrum1D objects. Is...
@pllim : something like that. But I thought we were no longer supposed to use six? And will this work for the extinguish member function that is only defined in...
@pllim : I checked if the inheritdocstrings added in the extinguish function to the docs for the different dust model classes. It did not. In fact, it made the building...
That does work. But now there are *lots* of member functions - all of those associated with these classes inheriting the astropy model functions. Need to think about this and...
F99 should already be in as a separate model. At least the R(V) dependent model presented in F99 is in. See the docs. :-) But, is there something akin to...
What would be the reason for having the F99FM07 hybrid model? Ideally, I would guess that FM07 and FM09 would be the two new models to add.