Karl Gordon comments

Results 228 comments of


                                            Karl Gordon

Set input_units, return_units, input_units_equivalencies, and bounding_box to use astropy's built-in input preparation?

I would definitely entertain such a PR. One question, would this allow for *no* units to be passed and interpreted as wavenumbers (1/micron)? Not allowing this is not a show-shopper,...

Set input_units, return_units, input_units_equivalencies, and bounding_box to use astropy's built-in input preparation?

Closing as not possible (see closed PR#238). Some capabilities implemented in PR #240.

New BEAST Tutorial!!!

Superseded by #838.

Add SpectralUnitsWarning for more targeted warning filters

Please add a description to this PR to describe in words the goal. Thanks.

Allow custom dust models

If someone want's to work on this, I'd be happy to support. I would suggest that using the dust_extinction package would be a good way. Note there is the G23...

Added kwarg to convert_hdf5_to_fits to consistently trim too-long column names

> Unsure what the coverage issue is... Is that just because the new kwarg isn't True by default, and isn't in the tests? This means the test coverage has decreased....

Added kwarg to convert_hdf5_to_fits to consistently trim too-long column names

> Doc test fail from ACCESS, as with prior PR, and some ADS timeouts? Anyways, not at our end. Yep. Might have to give up on having that URL in...

Fix issues identified by Codacy

https://app.codacy.com/gh/BEAST-Fitting/beast/dashboard

Ast generation speedup

Please fix the codestyle errors. I often just run the "black" auto-formatter to avoid any codestyle issues like this.

Syntax error in beast_development.rst

Does this give an error or a deprecation warning? Curious as this will drive the priority of getting this fixed.