Karl Gordon
Karl Gordon
> * Something (plots and/or numbers) to show that the noise model isn't changing drastically between SD/background bins. This will help evaluate whether our bins are narrow enough. See #398...
I've moved to codacy from lgtm. See the dust_extinction package for an example. We could do this for PAHFIT.
Wouldn't mind learning about github scanning though.
Is the idea here to have pahfit only do line fitting based on area? Or are we going to still allow central intensity? If the former, then this PR is...
> Is the idea here to have pahfit only do line fitting based on area? Or are we going to still allow central intensity? If the former, then this PR...
> The new model will use power exclusively for lines and dust features. So it’s a good idea IMO to get the current astropy model to as well. I think...
> Actually all the tests need some attention I think (haven't looked closely at them). Tests always need more. But they are working at this point until this change is...
Briefly, the tests passed. See https://github.com/PAHFIT/pahfit/actions. ;-) Takes vigilance to keep them passing. BTW, I turned off email notification of failing tests long, long ago. Just too many!
Note that the tests are currently failing due to codestyle issues. We have quite a suite of tests to make sure all parts of the repository work including the code,...
Yes this can be done fairly easily.