jwst
jwst copied to clipboard
JP-2693: Flag groups do_not_use after detected ramp jumps
Resolves JP-2693
This PR implements the enhancement to the jump step where groups after detected jumps are flagged do_not_use. This "corrects" transients that have been seen to make the slope after a jump different than before. This PR allows for flagging to be different for two different jump thresholds.
The main changes are in stcal
and this PR provides the needed interface for jwst
.
Checklist
- [x] added entry in
CHANGES.rst
within the relevant release section - [x] updated or added relevant tests
- [x] updated relevant documentation
- [x] added relevant milestone
- [x] added relevant label(s)
I just changed ticket number '2963' -> '2693' in description.
If understand things correctly, the tests are failing as the version of stcal used for the tests does not include the changes needed for this PR. After the stcal PR has been merged, then maybe the tests will pass.
The tests pass on my computer when the appropriate branch on stscal (jump_transient_flag) is used.
Ready for review. Likely, the corresponding PR in stcal should be reviewed at the same time.
@cshanahan1 are you good with this now that all review comments have been addressed?
@karllark I think this PR branch may need to be rebased from master. Looks like conflicts are preventing the CI tests from running.
@karllark I think this PR branch may need to be rebased from master. Looks like conflicts are preventing the CI tests from running.
Done.
I think the remaining CI failures, which are confined to ramp_fitting unit tests, are due to other PR's included in the stcal 1.1.0 release, and maybe fixed by #6949 once it gets merged. Retesting that PR right now.
Codecov Report
Merging #6943 (abf8ce9) into master (e8318e6) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #6943 +/- ##
==========================================
+ Coverage 79.24% 79.26% +0.01%
==========================================
Files 414 414
Lines 37478 37508 +30
==========================================
+ Hits 29701 29731 +30
Misses 7777 7777
Flag | Coverage Δ | *Carryforward flag | |
---|---|---|---|
nightly | 79.23% <100.00%> (ø) |
Carriedforward from e8318e6 | |
unit | 53.09% <100.00%> (+<0.01%) |
:arrow_up: |
*This pull request uses carry forward flags. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
jwst/jump/jump.py | 100.00% <100.00%> (ø) |
|
jwst/jump/jump_step.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
OK, #6949 has now been merged to update the truth values in the unit tests that were causing CI failures. So one more rebase to kickoff the tests again.