Karol Bucek

Results 252 comments of Karol Bucek

I tried and can get the `allocate` working in a way where the hash is [pre-allocated and avoid allocating twice](https://github.com/kares/jruby/commit/c0a6e452a58cb792f6eade550970f46bdd8ff55c). but I do not think `allocate` is the issue, with...

seems like we need a new [snakeyaml-engine for this](https://bitbucket.org/snakeyaml/snakeyaml-engine/pull-requests/16/diff), which isn't part of any release, yet. not going into building that myself, can try again once it's released...

:+1: great work, the `500ms` is tempting but I am not convinced it should be set (but also have no objections against). was wondering if reducing `-XX:MaxTenuringThreshold=8` would reduce the...

yeah those low hanging flags weren't mean to make a difference - just to check everything is the same as before ... even reducing `-XX:MaxTenuringThreshold=8` might not show much but...

:+1: looks like a good start but the PR feels incomplete. my idea about supporting jakarta/javax.servlet at the same time would have been converging towards moving all .rb bits that...

> @kares Are you opposed to this clean break, branching off 1.2.x and releasing a 2.x that uses only jakarta packages going forward? Not at all, just shared my personal...

> My main concern about this if this makes it harder to get to a supported Rails version I believe your concern, despite having an "unusual" app, is one shared...

Interesting, have considered Spring to be conservative - that feels like quite the jump they made with JakartaEE 9.0. Spring was brought in simply because of having the `ServletContext` mock...

and before I forget due jruby-rack being both a Java library as well as a Ruby gem, assuming the 1.4.0 release is not `javax.servlet` retrofitted but "only" a full `jakarta.servlet`...

for the record `catWithCodeRange` was added in [9.4.7.0](https://github.com/jruby/jruby/blob/9.4.7.0/core/src/main/java/org/jruby/RubyString.java#L1416) and isn't available in older JRuby versions