Karol Bucek

Results 252 comments of Karol Bucek

thanks, for reference it's also been feature requested to support encoding with the codec https://github.com/logstash-plugins/logstash-codec-netflow/issues/185

^^^ these sound more like ECS "enhancements", please review @yaauie

> These fields are now duplicated and takes a lot of space. This should be using @metadata instead. `data_stream.type` etc fields are of a constant keyword type (unless the mapping...

Thanks for the report, LS 6.3 is not longer supported. Could you try with latest LS 7.x if the issue still persist?

:100: Chad, this is looking great :green_heart: indeed, it's been a while since 1.1 was merged to master (mostly due always being in a rush when working on yet another...

That looks okay, in terms of the intent of the Logger implementation defaults changing in 1.2.0. Unfortunately, I am not fully up to speed and do not have an app...

> Should we have some smoketest set up? I feel like this project has languished due to lack of knowing if it is safe to release. I usually had a...

:+1: definitely, I recall those test from the main jruby repo. although they were a little opaque to debug, the benefits are clear for a project such as jruby-rack. believe...

> and decided the custom approach was still needed??? yes, unfortunately the ASN.1 parsing isn't 100% complete and there are differences in how the `ext.value` is presented. there were changes...

a.k.a. ``` jruby-9.1.7.0 :001 > while true jruby-9.1.7.0 :002?> return 1 jruby-9.1.7.0 :003?> end Unhandled Java exception: IRReturnJump: ```