Karol Bucek
Karol Bucek
for the record: https://github.com/jruby/jruby/pull/7762 addressed the main (contention) issue. but the degradation compared to 9.2 is still there and will require more work to avoid the extra code in Ruby...
a script that demonstrates single thread perf: https://gist.github.com/kares/f51f8a517d176fd2fdae52471aa7859e (degradation seems to be ~ 10x)
Did this happen for older JRuby versions, or has this been only observed with 9.4.6 (maybe it's new functionality, would be good to know if not) ?
I honestly do not know, have no solid ideas really... What I did find weird around `ARGV` is that internally JRuby engine [converts](https://github.com/jruby/jruby/blob/master/core/src/main/java/org/jruby/embed/jsr223/Utils.java#L242-L246) from `"javax.script.argv"` to `"ARGV"` as well as...
``` > Task :compileJava FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileJava'. > Could not resolve all files for configuration ':compileClasspath'. >...
yeah it works, but this is just a repro which is hard to work with - JRuby is hidden behind a dependency's dependency. and the error is just coming out...
> You poked around this code in 2015... maybe you can remember a bit about that process and offer some suggestions? not really - think I just wanted to fix...
great summary, as noted on the other thread I am also interested in reification being improved/reliable. probably in a way you mentioned (don't care for having it on by default...
> Preferably, we would also include a non-breaking release of this gem for inclusion in 7.x that used the deprecation logger to warn off users who exploit the current implementation....
changed the work here to be a major and also included another backwards compatibility "breaking fix" for #60 (to be merged/released before LS 8.0 is in the works)