Gil Pedersen
Gil Pedersen
Fix a pre typing issue? Can you elaborate? To me it reads like you _created_ an issue with this PR.
Yeah, hapi would probably need to expose this. But we can't call any `AsyncLocalStorage` logic, since this needs to be exclusively managed by the user, as there is only one...
Fixed in https://github.com/hapijs/hapi/commit/eb3d60a9b2420c688a372ff083f229055137aa2e.
The node 18 test failures are not related to this patch. It seems that it has been updated to no longer process requests after the listener has been closed.
The main issue seems to be that `readable-stream` includes a broken-on-require unused internal module (`lazy_transform`). This is a problem since bundlers / transpilers / test runners can sometimes recursively load...
Yeah, this issue concerns a runtime feature, which cannot go in a regular test case. Still, it is important to make the CI fail on this usage, so future code...
I would definitely like to see `cause` supported. We will have to be careful to not rely on the `Error` constructor option for this until node 16.10+ is required. For...
Your suggestion seems very sensible (except that all args should be optional): ```js type HelperMethod = (messageOrError?: string | Error, options?: Options) => Boom; ``` For `unauthorized()` the current lack...
The `LOCK` file would still be needed to prevent unintended write opens, or opens of an already locked db. Only it should use type `F_RDLCK` instead of `F_WRLCK`.
`comparePrototypes` is only supposed to work for `equal()` / `equals()`. You should be able to workaround this by checking each array element yourself using `equal()`.