Gil Pedersen
Gil Pedersen
You are probably not seeing the stack trace since you are using a not yet supported node runtime (v21.x), where they can go missing due to a change described in...
This issue seems to be a fallout of a decision to [strip `content-length` headers in passthrough mode](https://github.com/hapijs/h2o2/commit/7988c2dd1774be7541b3b54b4fd3ebf860323e82), which broke DELETE proxying. A fix was applied in https://github.com/hapijs/h2o2/commit/3e695df1904c15f0521775a6150a1d832da654e0, but this has...
Another related h2o2 issue, seems to be that it does not strip [hop-by-hop headers](https://www.rfc-editor.org/rfc/rfc9110.html#section-7.6.1) (including the already know ones), which can mess up the connection to the proxied server. Again...
> Route is available on the request object (see https://github.com/hapijs/hapi/blob/master/API.md#request.route) so I believe the hook on route _entered_ is not necessary. `request.route` won't be available yet when `onRequest` is triggered....
Regarding channels, I would advocate on limiting it until there is a concrete need. Eg. with just the `onServer` channel, APM's should be able to hook something that matches `hapi.onRoute`,...
I would much prefer that this PR does not add any more channel hooks. Ideally each hook gets a PR to allow simpler reviews. Eg. i have comments regarding `hapi.onError`,...
Hapi doesn't do anything with the FQDN, except [pass it to the node http server `listen()`](https://github.com/hapijs/hapi/blob/23d65502a6cf5372f6db0acfaac9a5188b9050cd/lib/core.js#L339-L340) method, documented [here](https://nodejs.org/api/net.html#serverlistenport-host-backlog-callback). FYI, the DNS resolution behaviour [has been changed in node to...
Thanks for the PR. Just for reference, `@hapi/iron` is already an implicit dependency of hapi through the `@hapi/statehood` dependency. While it doesn't change the installed code, I'm not a fan...
Statehood [re-exports the iron types](https://github.com/hapijs/statehood/blob/364f7dfefd568288f05135af82f4446ed8db9c21/lib/index.d.ts#L4), so a better fix is to just import those instead.
Yeah, hapi should not import typings directly from joi. I don't know if your suggestion will work, and suspect that it can cause other issues when used. The real solution...