Gil Pedersen

Results 191 comments of Gil Pedersen

Your cookie is not valid according to [the spec](https://www.rfc-editor.org/rfc/rfc6265#section-4.2.1) (`=` is required for each pair). The parsing behaviour changed with #81. Why do you need to parse invalid cookie strings?

Hmm… I'm not sure there is a good solution for this class of problem. We could revise the parsing to account for this specific case, but any such a tweak...

> If we're in agreement about all that, I take this report to be about the fact that with `ignoreErrors: true` (since a parsing error occurs on both 7.0.4 and...

Thanks for the investigation! This is just an another special object case for `Hoek.clone()` to handle. It already handles many other language level types this way. I made a fix...

We use the clone to guard against subsequent manipulation by the caller. Eg. ```js const baseUrl = new URL('https://hapi.dev/'); const wreck = Wreck.defaults({ baseUrl }); baseUrl.hostname = 'google.com'; await wreck.get('/api/');...

It could just be because `git clone git://github.com/hapijs/vision` fails: ``` Cloning into 'vision'... fatal: unable to connect to github.com: github.com[0: 140.82.121.3]: errno=Operation timed out ``` In any case it is...

FYI this is an issue across the hapijs ecosystem, and eg. [hapi itself](https://github.com/hapijs/hapi/blob/b8ba0adc7c3255995cb56a9a740c4f9750b80e6b/package.json#L6) has a bad value. It seems that [inert](https://github.com/hapijs/inert/blob/1bd7528be81051f9f18d4a44e29b963571f19424/package.json#L5) is fine, since I apparently had the prescience to...

Additional properties could be specified using an object: ```js { …, set: { Partitioned: true, OtherName: 'TheValue' } } ```

This sounds like a very sensible request, especially since you sometime can't control what charsets are used to upload text. I would probably limit it to `'utf8'` by default, but...

I agree. The typings are incorrect, confirmed by the API docs, and the code and tests. Except for `type: 'handler'`, the accepted type is `any`, as the value is just...