Gil Pedersen

Results 191 comments of Gil Pedersen

Maybe node needs to change its guidelines to not test for `err.name === 'AbortError'` (like [in stream](https://github.com/nodejs/node/blob/e0233fc7dc90bad14f7a38c2f2cf7e7a46a21e9c/doc/api/stream.md?plain=1#L2371)), but instead just test `signal.aborted`?

I took the liberty of creating a PR that removes all references to the internal `AbortError` and uses `signal.aborted` to detect if an error is from an abort: #40883 Let...

Yeah, I'm not sure about producing a test case. Currently, I make it fail by disabling / re-enabling my wifi during a heavy download from a remote server (using node...

I tried running with `NODE_DEBUG=http2`, and found that the unerrored prematurely closed responses close while `readable true`, while all other responses have `readable false`. ``` HTTP2 93829: Http2Stream 19 [Http2Session...

I have not been able to create a test case, but I can present more details: This issue is server dependent. If I use nginx termination instead of envoy, it...

Digging into envoy, I found further evidence to the theory, as it can indeed [send RST frames with `NGHTTP2_NO_ERROR`](https://github.com/envoyproxy/envoy/blob/e9e773c840c62ad34200bc864e1edb3d31c6d617/source/common/http/http2/codec_impl.cc#L513-L519).

Yup, this is an nghttp2 issue, as speculated. Though, any fix will take some time to arrive in node, so it might make sense to add a workaround here? The...

I made a failing test using http2 streams here: https://github.com/nodejs/node/issues/35209#issuecomment-700247360. I also managed to find problems when a server closes the stream with `RST_STREAM` code 8 (CANCEL): https://github.com/nodejs/node/issues/35209#issuecomment-700249929

If you want to work around this last bug, you could check the stream `rstCode` property when the `end` event is emitted (it will be 8 when aborted by the...

@turbopasi It should be a property on the `got.stream()`.