kangalio

Results 245 comments of kangalio
trafficstars

> those effects won't be reflected until you use it as a builder Ah I see, thanks for explaining your mental model. I'll change this PR to use newtypes instead...

> Scratch what I said in my earlier comment; since builder fields are private, there isn't really any other way to instantiate them than with the builder methods. Therefore, exposing...

You're right that idea would need much more consideration and experimentation --- Independent from that; are there other doubts or blockers about this PR?

I can't do this I tried to rebase this fucking PR three times Every time git fucked up. Duplicating code; trying to smuggle outdated code in; removing important code; breaking...

Is it worth the churn? [referring to the "removing CacheAndHttp" part]

For #2138, I was thinking of storing CurrentUser in CacheAndHttp as a third field. Could we keep CacheAndHttp for now to keep that possibility open?

Ah look what's failing the CI: now-functioning Clippy warnings!

Totally forgot about them. Will do later

Can't reproduce ([terminal log](https://pastebin.com/qbK2FuD1), Arch Linux too) If I remember correctly, incremental compilation sometimes spazzes out and causes crashes like this. In those cases `cargo clean` usually helps