kangalio

Results 246 comments of kangalio

I agree; there's a trade-off here, but we're better off not introducing an extra set of methods with `&mut self`

There's also options like https://docs.rs/replace_with ```rust fn foo(builder: &mut CreateEmbed) { replace_with_or_abort(builder, |b| b.name("test-channel")); replace_with_or_abort(builder, |b| b.topic("example topic")); } ``` Or macros ```rust macro_rules! set { ($b:ident $( $rest:tt )*)...

> You also need to take special care not to build an invalid combination of options. To give an example of this which I just encountered in my code: to...

Another thought I had: maybe the replied_user setting should be moved out of the CreateAllowedMentions API entirely? I think allowed_mentions was an unintuitive place for Discord to put the inline...

This issue can be closed I believe

I just attempted to re-implement this PR to be able to close this outdated one. I don't think this is a good idea. CommandData is now wrapped behind an Option...

Clean diff: b4b8bd446d25a687d08e9d348cf744cf6c718346

The code in question doesn't exist anymore (the whole voice module is gone), so this issue can probably be closed?

Related: https://github.com/serenity-rs/serenity/issues/1905