kangalio

Oh I'm only seeing now that GitHub capitalized my `panic`. It was supposed to be lowercase

This doesn't work for whatever reason. No exception, but when retrieving the HAR, there are no entries at all. ``` server = ProxyServer("browsermob-proxy-2.1.4/bin/browsermob-proxy") server.start() proxy = server.create_proxy() driver = webdriver.Firefox(proxy=proxy.selenium_proxy())...

Yes, a Deserializer invokes `visit_map(map: impl MapAccess)`. We have two Deserializer's, but need both MapAccess instances to build the struct. Hence we need a temporary storage

What are others opinion on this topic?

 There are a lot of `Vec`. HashSet has higher overhead (2x stack size, 3x slower in ad-hoc benchmark), which makes me reluctant to change all those to HashSet. Do...

Instead of storing CurrentUser directly, there should probably be a new struct `BotContext` or `BotInfo` or similar, with fields for `CurrentUser` (useful for bot ID, name and discriminator), `CurrentApplicationInfo` (useful...

I'm thinking about an alternative way to achieve the goals: have `cache` be always on and instead add configuration for how much data is cached. That way, the absolute bare...

This PR is never gonna be ready in its current state, and #2210 is a better way of achieving the goals anyways

> From my point of view, those methods make no sense to call on a model type that was returned from the API Can you explain why you feel that...

What I mainly find interesting about this PR is how it shows that we don't _really_ need the noisy methods on builders anymore (independent of deduplicating them with model types;...