serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Published 20 hours ago • verified publisher icon serenity-rs

Deny Clippy warnings in CI

Open kangalio opened this issue 3 years ago • 2 comments
trafficstars

With this, Rust and Clippy warnings should actually be caught in CI

kangalio avatar Sep 18 '22 15:09 kangalio

Ah look what's failing the CI: now-functioning Clippy warnings!

kangalio avatar Sep 18 '22 15:09 kangalio

Rust 1.64 brought some new lints, particularly one showstopper that I already addressed in #2174. But, as it stands, feel free to fix the rest with additional commits to this PR.

EDIT: Some of the lints were actually part of 1.65, my mistake. Right now, on 1.64, the current branch does not trigger clippy.

mkrasnitski avatar Sep 23 '22 02:09 mkrasnitski

@kangalioo Thoughts on the suggested changes?

mkrasnitski avatar Sep 27 '22 12:09 mkrasnitski

Totally forgot about them. Will do later

kangalio avatar Sep 27 '22 12:09 kangalio

I think you missed warn(unused), unless it's implied by something else.

mkrasnitski avatar Sep 29 '22 18:09 mkrasnitski

LGTM!

mkrasnitski avatar Sep 29 '22 23:09 mkrasnitski