kangalio

Results 208 comments of kangalio

Perhaps the docs could point to the Cargo.toml? The Cargo.toml contains the ground truth - the feature names, the inter-feature dependencies, and the feature docs, all in one place. If...

According to [convention](https://rust-lang.github.io/api-guidelines/naming.html#ad-hoc-conversions-follow-as_-to_-into_-conventions-c-conv), the methods should use the `into` prefix instead of `to`

This is implemented in #947. You can check in dtolnay's unholy [triage list](https://triage.rust-lang.org/notifications?user=dtolnay) when he finally gets around reviewing it [man please allow more maintainers to join :sob:]

https://github.com/serde-rs/serde/issues/1070 is locked so I can't post it there, but if https://github.com/rust-lang/rust/issues/39935 goes through, the Result impl can be deprecated. That way, someone cannot use that impl accidentally anymore

I wonder if the additional complexity is even worth it. I feel like that Spotify API feature is mainly useful for dynamically typed languages, where specifying the fields you're working...

> a proof of concept to test if it actually made a difference for my workflow (fetching the IDs of all tracks in a playlist), and the speed difference was...

Is this still an issue on the `next` branch? If so, how to reproduce?

Can't reproduce & no response from author [serenity-870-test.zip](https://github.com/serenity-rs/serenity/files/11180056/serenity-870-test.zip)

> Ideally, we would also have a tool that parses serenity source code using syn and scrapes Discord API docs, to make sure serenity's model types have correct fields and...

Also, such a tool isn't needed because Discord announces new API features. So we'd only need to invest a one-time effort of going through all structs and updating them according...