kangalio

> First I must correct myself. The example enum in my previous comment should of course not has the deny_unknown_fields attribute. That was the entire point. Can you edit the...

> ```rust > #[derive(Deserialize, Debug)] > struct ErrorStruct; > > #[derive(Deserialize, Debug)] > #[serde(tag = "result")] > enum Response { > Success(()), > Error(ErrorStruct), > } > ``` > >...

I had assumed it's a non-goal for serde-json to preserve order of maps. As long as `preserve_order` is not enabled, the user shouldn't rely on any particular ordering or sorting...

I think a type annotation is the best way to solve this, yes. This seems more like Rust's fault than serde-json's. A PartialEq in some dependency crate shouldn't be able...

See the `preserve_order` feature https://github.com/serde-rs/json/blob/931ee23b1abf6b302df7c20a3a5866bf1a8a33ca/Cargo.toml#L58-L61

Ah, I can see how consistency to the other two authentication methods is nice. Still, for me as a fresh user of RSpotify, auto-authentication in ClientCredsSpotify seems less surprising and...

Another valid inprovement suggestion lost to the relentless bug report steamroller called stale bot :'(

I don't think this is something serenity should implement, being an unopinionated library. Why do you need this feature in serenity, when it is provided by poise?

There is not, unfortunately

> but I don't see why this feature is considered opinionated, it's quite important True, I was sloppy with my wording. When I said opinionated, I really meant something different:...