serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Webhooks don't follow rate limit

Open vicky5124 opened this issue 4 years ago • 1 comments
trafficstars

The cause of the issue that happened on #1120 has been determinated to be webhooks not following the rate limits. Both issues should still be fixed though.

vicky5124 avatar Dec 10 '20 21:12 vicky5124

Maybe this is related to all of the following requests sharing the same ratelimit bucket (Route enum variant)?

  • GetWebhook(WithToken)
  • CreateFollowupMessage
  • DeleteWebhook(WithToken)
  • EditWebhook(WithToken)
  • ExecuteWebhook

kangalio avatar Sep 19 '22 07:09 kangalio

Is this still an issue on the next branch? If so, how to reproduce?

kangalio avatar Apr 26 '23 07:04 kangalio

This shouldn't be an issue anymore, as the x-ratelimit-* headers are now followed on webhooks, when they didn't used to. More details in #1120

vicky5124 avatar Apr 26 '23 11:04 vicky5124