kangalio comments

Results 208 comments of


kangalio

Generic async function `not_send`

> > the returned future is not `Send` only if `R` isn't > > So then shouldn't you add the constraint `R: Send` to ensure that the future is `Send`?...

IoVec::from_mut_slice and vmsplice are unsound

Oh wow, it's more type-safe, exists in the standard library, is stable, and that since 1.36. Awesome! The vmsplice issue is still there; the argument is still immutable ![Screenshot_20220127_180630](https://user-images.githubusercontent.com/21220820/151408047-1fa4be34-20f5-47f4-92bf-c036bf958b6d.png)

ANSI escape codes in Miri output

Caused by https://github.com/rust-lang/miri/issues/2277

Set `incremental = true` for builds that don't output LLVM IR

After experimenting with cargo locally for a while, I believe the culprit is not `incremental = false` but `codegen-units = 1`. In a test, I set `codegen-units = 1` and...

Why does the callback for MidiInput::connect need to be 'static?

To summarize: the callback for MidiInput::connect needs to be 'static, because the `MidiInputConnection` handler type may be leaked via `std::mem::forget()` (which is allowed and totally safe in Rust). If `MidiInputConnection`...

Problem deserializing adjacently tagged enum with default content

Related to #2248

Deserialize empty map into None

This needs to be fixed in serde's Deserialize derive macro, not serde-json. You could repost this issue there: https://github.com/serde-rs/serde/issues/

Why does `serde_json::Value::as_array` return `Option<&Vec<Value>>` instead of `Option<&[Value]>`?

> Because in the case of Option it returns a pointer to a chunk of then original JSON doc (which is a giant string) That is not true. We're talking...

Document behavior of to_pretty_string when passing Value

Looking at the source code, it seems `Value`'s `Serialize` impl indeed cannot fail: https://github.com/serde-rs/json/blob/931ee23b1abf6b302df7c20a3a5866bf1a8a33ca/src/value/ser.rs#L13-L36 I think a PR to state this in the docs is a good idea, although the...

Question: Possible to generate a json stub without providing a value?

> serde_json should technically be able to generate these stubs without requiring a default I think? You mean, serde_json would generate the default values for each field itself? Wouldn't that...