Kevin Anderson
Kevin Anderson
I can do a review (sorry for the wait!) but I'm a little hesitant about the current approach this PR takes. To me, this code feels more like an application...
I think my hesitation was centered around not being able to use the addition function with the existing methods for generating IV curves. It felt somewhat disconnected from the rest...
> Is this already in pvlib.bifacial.infinite_sheds [here](https://github.com/pvlib/pvlib-python/blob/7bb30ad6e9d599d10510c7b37d95d56f14e846b4/pvlib/bifacial/infinite_sheds.py#L341)? #717 originally had that code as a public function in `pvlib.shading` but later changed it to be private. I can't quite remember why....
I think this could use another set of eyes -- I'm having some trouble wrapping my head around testing with and without numba and I'm not sure what I'm doing...
@langestefan can you say more about what "replace pandas with polars" would mean in this context? Not supporting pandas inputs, or changing our docs to use polars instead of pandas,...
As I understand it, dicts being ordered according to insertion was a CPython implementation detail in 3.6 that got upgraded to an official language feature in 3.7 onward, so it...
Regarding enabling `nitpicky`, the signal to noise ratio of its output is not very good at the moment. Here is the log I'm looking at: https://readthedocs.org/api/v2/build/21309664.txt About 1500 warnings, most...
I do not know the details, but I hear that the AM 1.5 reference spectra are currently under revision, or perhaps have already been revised. The NREL NSRDB team had...
Yes, I believe [ASTM G173-23](https://www.astm.org/g0173-23.html) is the update to which I am referring. I will ask if NREL plans to make the revised spectra public.
I heard back that NREL intends to update their webpage with the latest tables, but it may not happen for a while. I think we should proceed with the older...