Kevin Anderson

Good to know about `importlib.resources.files`! It does require python 3.9 though. > The function name get_test_dataset_path implies that it's only for tests, yet it's used for all 3 of those...

Or #974. > If the blue line above from the precise IV curve, would it be possible to make it even more precise, or perhaps more ideal, by removing the...

The convergence error discussed above is large enough to make me uncomfortable, but probably not too large to keep the method from being useful. The other thing is that only...

> Importlib imports the whole module with importlib.resources.files('pvlib'). I don't know how much overhead that introduces compared to using `__path__[0]` or `__file__`, but I expect it to be a little...

Note that pvlib has a function that uses `scipy.optimize.brentq` with `pyephem`: [pvlib.solarposition.calc_time](https://pvlib-python.readthedocs.io/en/stable/reference/generated/pvlib.solarposition.calc_time.html).

I am also hesitant to directly dump the tutorial notebooks into a new `Tutorials` docs section. My concerns: 1. There is certainly good content in them, but some of the...

I think there is room for these kinds of models in pvlib. @kurt-rhee is a paper for this model in the works? I need to read that docs page in...

> One disadvantage may be that we lose view factor as a function of location on the ground I don't see any reason not to retain the current `vf(x)` functions....

@mikofski can you comment on the relationship between this shaded fraction calculation and the one in section 6 of [Slope-Aware Backtracking](https://www.nrel.gov/docs/fy20osti/76626.pdf)? They seem quite similar in spirit, to me at...

Thanks @echedey-ls for looking into docstring linters in support of this PR! Too bad none of these linters turned out to be directly applicable to this specific PR. Adding custom...