Kamil Mysliwiec

icon indicating a website link https://kamilmysliwiec.com icon indicating an email [email protected]

icon company @nestjs icon location Poland icon location Creator of @nestjs. Co-Founder of @TrilonIO. @google Developer Expert. Speaker, Trainer and Consultant. OpenSource (OSS) enthusiast.

Results 536 comments of Kamil Mysliwiec

route exclusion from the setGlobalPrefix not taken in account when enableVersioning is set

Let's track this here https://github.com/nestjs/nest/pull/11650

feat(microservice): add grpc status enum

I think this should be added to the grpc library, not the framework itself. Thanks for your contribution anyway!

Fix HTTPException on minifying class names, its not match regex expre…

LGTM

refactor(): refactor exception handlers

LGTM

start:dev runs on previous saved version (not current)

This doesn't seem to be related to Nest.

feat(types): Type check Field defaultValue

PR looks great! However, we can't merge it in yet as it introduces a (minor but still) breaking change (even though in theory it shouldn't break when `defaultValue` was used...

Fix: doc versioning by header

Apologies for not reviewing this sooner! Could you please resolve conflicts? Also, any chance we can add an e2e test too (with enabled versioning by header)?

Fix: doc versioning by header

We're still waiting for e2e tests to be added

fix: update jwt module to use module options builder

This change shouldn't have any impact on the behavior of the module.

feat(resource): cqrs schematics

Thanks for your contribution @TripShade! However, there are no plans to add more schematics to the official collection. You can release your own CQRS schematic as an open-source, community-driven NPM...