swagger icon indicating copy to clipboard operation
swagger copied to clipboard

Published 20 hours ago • verified publisher icon nestjs

Fix: doc versioning by header

Open kperreau opened this issue 2 years ago • 4 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features) ???

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: 1495

What is the new behavior?

Versioning documentation is now working for header versioning.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

kperreau avatar Aug 31 '22 09:08 kperreau

Apologies for not reviewing this sooner!

Could you please resolve conflicts? Also, any chance we can add an e2e test too (with enabled versioning by header)?

kamilmysliwiec avatar Feb 06 '23 13:02 kamilmysliwiec

Any updates on this? Looking forward to being able to use it! :)

david-induro avatar Jul 20 '23 15:07 david-induro

is there anything remaining to merge this? happy to contribute to this PR to get it merged

jointhejourney avatar Oct 17 '23 06:10 jointhejourney

We're still waiting for e2e tests to be added

kamilmysliwiec avatar Oct 23 '23 09:10 kamilmysliwiec

Any news on this?

dalaverd avatar Jun 26 '24 20:06 dalaverd