jwt icon indicating copy to clipboard operation
jwt copied to clipboard

fix: update jwt module to use module options builder

Open floross opened this issue 3 years ago • 5 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: Fix #1064

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

floross avatar Aug 26 '22 19:08 floross

please revert the changes made on package.json file

It should be good now, I revert the package.json and package-lock.json

floross avatar Aug 29 '22 13:08 floross

Do you have any update on when we could merge this pr into master?

floross avatar Sep 14 '22 19:09 floross

Any updates on this PR?

allanvobraun avatar Nov 09 '22 19:11 allanvobraun

@kamilmysliwiec This feature would be very useful to us, is there anything we can do to help this getting merged?

milo526 avatar Dec 06 '23 11:12 milo526

This change shouldn't have any impact on the behavior of the module.

kamilmysliwiec avatar Dec 07 '23 07:12 kamilmysliwiec