Kamil Mysliwiec

Results 498 comments of Kamil Mysliwiec

> Honestly I'm not sure, I just tried on a new project and it closes open connections with the default. Here is the current implementation of the closeOpenConnections method `this.openConnections`...

@soryy708 could you spin up a pure express application (non-NestJS-driven) just to see what's the original behavior for your test?

If this behavior can be reproduced with the pure express application, then I don't think there's anything we can/should do given we don't really want to alter the default driver's...

Given that this is the default behavior of HTTP drivers we rely on (Nest is built upon), I wouldn't even call this an "issue" but rather a "feature request". Whether...

> It's the default behavior of Express without anything, because Express is not a framework like Nest is. This doesn't imply we should be changing the driver's default behavior, especially...

> I can see how this issue pops up for regular health checks. But this can also be useful for SSE! I think we should consider keeping this logic in...

Have you tried using this package https://www.npmjs.com/package/nestjs-graceful-shutdown?

Would you like to create a PR for this feature?