Wael Nasreddine

Results 159 comments of Wael Nasreddine

@ruimarinho Do you mind taking a look if this implementation is satisfactory to close #56?

This was introduced in d7d7375f3f3fc28bf57fbeff24aef9b8c2079244, and the last commit I can get debug logging on is 0a1730104d1767e9efd7502d93e39af45bf9c73b.

Hey, I have not used it myself for a while. It's very possible that it stopped working. I won't be able to spend time on it myself so I would...

@kai5263499 here's mine ``` { "cacheFile": "/Users/kalbasit/Library/Caches/com.appspot.go-acd.cache", "timeout": 0, "tokenFile": "/Users/kalbasit/.config/acd-token.json" } ```

@dsoprea thinking about this, we need to split this into multiple PRs. See https://github.com/go-acd/acd#commit-style-guideline

That's because we cache the node tree, it's an expensive operation to do at every run. We should perhaps add a flag like `--no-cache` or `--refresh-cache` to force cache pull.