Quotes, URL, Bugfixes, Docs Changes

[dsoprea]

Added documentation about the configuration file format. This was needed in order to know how to even run acd. Expanded "get" instruction to also describe build and run. I also added an example execution of acd ls. Since this requires a special "acd://<...>" URI to be given, it wasn't intuitive how to do this without the help.

Added the ability to provide the token-server URL via the config (and removed your to-do comment regarding the same).

Added quotes to short-listing (otherwise it's very confusing when filenames include spaces). This will slash any existing quotes in the names.

When I deleted something via the Amazon UI and attempted to list via acd, it started crashing. I had to add a check for whether c.NodeTree was non-nil before calling Close() on it from Client's Close(). I was still getting an index/range error, so I also needed to update the prune routine to do the (len - 1) things only if there are other nodes.

closes #8

[dsoprea]

Hmm. Confirmed. I had missed that in the beginning.

Dustin

On Sat, Mar 4, 2017 at 1:25 AM, Wael Nasreddine [email protected] wrote:

@kalbasit commented on this pull request.

In README.md https://github.com/go-acd/acd/pull/6#discussion_r104281162:

-go get gopkg.in/acd.v0/...
+$ go get gopkg.in/acd.v0/cmd/acd
+$ go build gopkg.in/acd.v0/cmd/acd

@dsoprea <https://github.com/dsoprea> that's how go get works, it fetches
the library and then the dependencies and then installs it.

# go get -h
usage: get [-d] [-f] [-fix] [-insecure] [-t] [-u] [build flags] [packages]

Get downloads the packages named by the import paths, along with their
dependencies. It then installs the named packages, like 'go install'.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/go-acd/acd/pull/6#discussion_r104281162>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AArramMQdYQseDaPmkGAhD58ZR7lVeJgks5riQPogaJpZM4L-acl>
.

[kalbasit]

@dsoprea thinking about this, we need to split this into multiple PRs. See https://github.com/go-acd/acd#commit-style-guideline