Keith Wall
Keith Wall
I think we should close this PR. I don't think the proposed solution is the right one. The underlying issue is the fact that work in #74 is unfinished. The...
Closing, the ApiVersionsService is deprecated, we don't want to build more around the existing API. With the changes made available in 0.6.0 (specifically the range aware port per broker network...
That's a nice idea. I was thinking about putting the dummy Dockerfiles in `.github` but your way keeps the image ref closer to the code (and visible to the classloader).
This issue still exists https://javadoc.io/doc/io.kroxylicious/kroxylicious-runtime/latest/io/kroxylicious/proxy/internal/filter/ApiVersionsIntersectFilter.html is generating a link to https://kroxylicious.io/kroxylicious-api/apidocs/io/kroxylicious/proxy/filter/ApiVersionsResponseFilter.html this is because on https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#detectLinks which is using Kroxylicious's url declared in the pom + module name + apidocs....
We agreed that we would adopt DCO, and take the explicit path requiring --signoff.
# Automation changes required: ~~## asciidoctor-ghpages~~ ~~It looks like https://github.com/manoelcampos/asciidoctor-ghpages-action/blob/059c535f154a8a2853dc72b1ca5dd9c005d57d75/entrypoint.sh#L93 will fail. It appears like asciidoctor-ghpages doesn't have a mechanism to influence the parameters used by commit. t also appears...
gh-pages is on the kroxylicious repo. That's the repo we actually expect contributions.
@franvila error on my part, commit made by asciidoctor-ghpages isn't subjected to the DCO check at all. It pushes straight to its branch. The DCO check is applied to the...
@tombentley thanks for putting the proposal together. I really like it. `keyEncryptionKey` - should that be `keyEncryptionKeyAlias` or simply `alias` to adhere to the naming scheme already used by the...
I think this project might provide some inspiration. It uses the maven plugin to render to HTML. We might not want that part. The amalgamation using the assembly plugin might...