Keith Wall
Keith Wall
Follow on tasks. #1216 - Documentation for AWS KMS integration #1217 - AWS KMS serde improvements #1218 - Allow JdkTls class to be shared between KMSs (or Filters) https://github.com/kroxylicious/kroxylicious/issues/1219 -...
@tombentley > If we're not handling it/can't test it then failing with an exception seems like the right thing to do. I changed the code in `AwsV4SigningHttpRequestBuilder#signRequest` so that only...
I gave the implementation as it stands now another spin against real AWS. All seems to be working just fine. I even tried a key rotation. All good. I was...
@SamBarker can I get another re-review? hopefully this is close now.
It looks like this would be easily achieved. FilterChainFactory is created by KafkaProxy. It holds a reference to the `FilterFactory`s it has created.
Yes, the current scheme doesn't work well in the case you describe, or cases where say, broker ids start at an arbitrary high value, say 1000. I don't know how...
I think to solve this problem, `portperbroker` needs knowledge of the node ids that the cluster is actually using. Kroxylicious could **discover** the information from the cluster. That would be...
Yes, exactly, flattening the ranges into an array and calculating the index of the node id in that array. Thank you for the clarification.
Fixed by #1220. Thank you @robobario
Thanks for the feedback @franz1981, having your Netty expertise is really appreciated. Your whole comment wasn't super easy to parse, but I'm getting that when Netty 4.2 lands we'll be...