Keith Wall
Keith Wall
No imperative to work on this any time soon.
> One thing I'm not so sure about is the complexity of the interval notation. I can appreciate that it might be a commonly understood notation and gives users flexibility...
This looks really useful to me. I know in a past life, I'd have loved to been able to protect my Kafka Cluster from clients hammering it with duff tokens.
I ran up a test case using auth0.com as the oauth server. I notice a problem, the token validation is failing (it is an audience issue but the precise detail...
To work with auth0, I found I need to pass through the SASL_OAUTHBEARER_EXPECTED_AUDIENCE as a config parameter. With that in place, the happy path was good for my test case....
@callaertanthony I made a couple of suggestions in https://github.com/callaertanthony/kroxylicious/pull/2
Tested on the Mac with `./scripts/run-example.sh kubernetes-examples/portperbroker_plain`. lgtm! thank you @franvila
Note to self: work out why Localstack is so slow to startup. Edit: Fixed - upgrading knocked 10seconds of the startup time!!
Successfully tested end to end against real AWS. Todo: * ~~get rid of the if/then/else ladders `getTarget` nonsense~~ * ~~refactor the AWS request signing to be nice~~ * ~~work out...
I think this PR is now in a reviewable state. All feedback welcome. The _existing_ integration tests (`KmsIT`, `RecordEncryptionIT`) test against Localstack. I'm planning to leave the following for separate...