Keith Wall

Results 305 comments of Keith Wall

@luozhenyu thanks for the contribution and taking the time to benchmark. I think there's a couple of things for us all to discuss to help us decide the right path.

Hello @luozhenyu, I think it might help reviewers if you raise your Zero copy work (2nd commit) as a separate PR. It seems to be going quite a bit deeper...

@luozhenyu would you be able to respond to my comment above?

@luozhenyu thanks for the contribution. Can you tell me a bit more about how you hit the problem (what broker version etc)? Also can you tell me a bit more...

> My team have some unusual brokers which have strange broker ids. Oh right, so your real problem is the mapping of broker ids is too inflexible? We've actually seen...

I'm now reviewing this change (leaving aside the wider point #902 for another issue). So, I think you **must** be using a Kafka Client that doesn't send a API_VERSIONS of...

> I am using a standard Kafka 3.7.0 client and a kroxylicious with SASL enabled. What do you mean exactly by 'SASL enabled'? > The ApiVersionsIntersectFilter will be never called,...

> Yes, I modified the code of io.kroxylicious.proxy.KafkaProxy and inserted my customized authnMechanismHandlers. It'd been good to make that really clear in the description.

The api-version handling in authentication offload is really just a POC. As you'll have noticed it sends a hardcoded `ApiVersions-3.2.json` response to the client. That's not safe, it means that...